Snapshot support on supervisor #3062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
approved
sipriyaa
force-pushed
the
snapshot-supervisor-support-set1
branch
10 times, most recently
from
f55fac9
to
84f3b09
Compare
sipriyaa
force-pushed
the
snapshot-supervisor-support-set1
branch
4 times, most recently
from
5c9c6a1
to
af59ec0
Compare
sipriyaa
force-pushed
the
snapshot-supervisor-support-set1
branch
from
c1ed874
to
9bf7cf2
Compare
sipriyaa
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/approve |
sipriyaa
force-pushed
the
snapshot-supervisor-support-set1
branch
2 times, most recently
from
00cd63d
to
662ce86
Compare
rajguptavm
reviewed
Oct 18, 2024
rajguptavm
reviewed
Oct 18, 2024
sipriyaa
force-pushed
the
snapshot-supervisor-support-set1
branch
2 times, most recently
from
13fea09
to
5852883
Compare
sipriyaa
force-pushed
the
snapshot-supervisor-support-set1
branch
3 times, most recently
from
0dcc307
to
f0a7910
Compare
sipriyaa
force-pushed
the
snapshot-supervisor-support-set1
branch
from
459744a
to
59991ee
Compare
rajguptavm
reviewed
Oct 21, 2024
sipriyaa
force-pushed
the
snapshot-supervisor-support-set1
branch
2 times, most recently
from
c41bdd0
to
2b9fdda
Compare
rajguptavm
reviewed
Oct 22, 2024
sipriyaa
force-pushed
the
snapshot-supervisor-support-set1
branch
from
5d00dbc
to
91ed8db
Compare
rajguptavm
reviewed
Oct 23, 2024
rajguptavm
reviewed
Oct 23, 2024
sipriyaa
force-pushed
the
snapshot-supervisor-support-set1
branch
from
84bc1a1
to
7cb4399
Compare
sipriyaa
force-pushed
the
snapshot-supervisor-support-set1
branch
from
c078faf
to
57f27e0
Compare
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kavyashree-r, rajguptavm, sipriyaa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR includes existing snapshot-related code changes and additions to support snapshots on Supervisor components such as PodVM, VM Service, Stretched Supervisor, and Multi SVC.
Testing done:
Yes
Supervisor Logs:
supervisor-logs.txt
Lint Check:
sipriya@C02CR8ENMD6M vsphere-csi-driver % golangci-lint run --enable=lll
sipriya@C02CR8ENMD6M vsphere-csi-driver % make golangci-lint
hack/check-golangci-lint.sh
golangci/golangci-lint info checking GitHub for tag 'v1.59.1'
golangci/golangci-lint info found version: 1.59.1 for v1.59.1/darwin/amd64
golangci/golangci-lint info installed /Users/sipriya/go/bin/golangci-lint
INFO golangci-lint has version 1.59.1 built with go1.22.3 from 1a55854a on 2024-06-09T18:08:33Z
INFO [config_reader] Config search paths: [./ /Users/sipriya/snapshot-supervisor-support-set1/vsphere-csi-driver /Users/sipriya/snapshot-supervisor-support-set1 /Users/sipriya /Users /]
INFO [config_reader] Used config file .golangci.yml
INFO [lintersdb] Active 8 linters: [errcheck gosimple govet ineffassign lll misspell staticcheck unused]
INFO [loader] Go packages loading at mode 575 (compiled_files|exports_file|imports|name|deps|files|types_sizes) took 1m3.638701092s
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 425.612542ms